pingcap/tiflow

Hide sensitive information in cdc log

Open

#859 opened on Aug 19, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Go (310 forks)auto 404
component/metrics-logginghelp wanted

Repository metrics

Stars
 (461 stars)
PR merge metrics
 (PR metrics pending)

Description

Feature Request

Is your feature request related to a problem? Please describe:

Some sensitive information should not be logged in cdc log, including:

  • database password
  • auth.token of mq
  • schema name and table name
  • table info

Describe the feature you'd like:

  • Hide all sensitive information, but the implementation way needs discussion

Possible solutions

  • Add one more sensitive log level
  • Add a sensitive data filter in log system, which user can configure what should be hided in log

Contributor guide

Research direction
Investigate the current logging implementation in TiCDC and identify where sensitive data is logged. Consider creating a configuration for logging filters or a new log level to mask sensitive fields.
Tech stack
go
Domain
backenddatabasesecurity
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60