pingcap/tidb

Wrong function comment for `UpdateGlobal`

Open

#61311 opened on May 26, 2025

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Go (40,090 stars) (6,186 forks)batch import
good first issueseverity/minorsig/sql-infratype/bug

Description

Bug Report

https://github.com/pingcap/tidb/blob/1c6c5ad2acd6d5d2d4eee9b80032181a8f936a65/pkg/config/config.go#L1396-L1402

There's no "restore function" returned by UpdateGlobal. The comment should be updated, or code should be aligned with comment.

Contributor guide

Tech stack
go
Domain
documentation
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
Look at the function `UpdateGlobal` in pkg/config/config.go around line 1396-1402. The comment incorrectly mentions a 'restore function' that doesn't exist. The issue may be resolved by either updating the comment to match the code or by adding the missing restore function. Check the issue comments for any maintainer guidance. No linked PRs exist.