pingcap/tidb

"The 'kill' or 'admin' operations do not accommodate user-defined variables.

Open

#55,369 opened on Aug 12, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (40,090 stars) (6,186 forks)batch import
help wantedseverity/moderatesig/sql-infratype/bug

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

set @id=100; kill @id; admin cancel ddl jobs @id;

2. What did you expect to see? (Required)

Query kill or admin is executed successfully; The behavior of MySQL is as follows

3. What did you see instead (Required)

4. What is your TiDB version? (Required)

mysql> select tidb_version(); +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | tidb_version() | +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Release Version: v6.5.6 Edition: Community Git Commit Hash: 8445821f105477d5e31de9d8451b7fbf35a02cd1 Git Branch: heads/refs/tags/v6.5.6 UTC Build Time: 2023-12-04 07:21:27 GoVersion: go1.19.13 Race Enabled: false TiKV Min Version: 6.2.0-alpha Check Table Before Drop: false Store: tikv | +-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.00 sec)

Contributor guide

Tech stack
gosql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingTiDB codebase structureSQL parsing concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate how user variables are resolved in TiDB's SQL parser. Focus on the KILL and ADMIN CANCEL DDL JOBS statements. Look at the implementation of these commands in the executor package and see how variables are substituted. Check if there are similar patterns for other statements that support user variables.
"The 'kill' or 'admin' operations do not accommodate user-defined variables. · pingcap/tidb#55369 | Good First Issue