pingcap/tidb

Mismatch unit of configuration item when set and then get config via SQL

Open

#51,740 opened on Mar 13, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (40,090 stars) (6,186 forks)batch import
affects-8.1good first issueseverity/moderatesig/sql-infratype/bug

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

set config tikv `raftstore.raft-entry-max-size`='24MB';

show config where type='tikv' and name ='raftstore.raft-entry-max-size';

2. What did you expect to see? (Required)

The output value should be consistent with the input '24MB';

3. What did you see instead (Required)

'24MiB'. In other words, MiB vs MB.

4. What is your TiDB version? (Required)

v7.5.1

Contributor guide

Tech stack
gosql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingSQL basicsTiDB configuration system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the SQL layer handling of config set/show commands. Look at how the unit string is parsed and converted internally. The issue likely lies in the conversion between user input (MB) and internal representation (MiB). Focus on files related to configuration parsing and SQL execution for config statements. Check if there is a unit normalization step that incorrectly converts MB to MiB.
Mismatch unit of configuration item when set and then get config via SQL · pingcap/tidb#51740 | Good First Issue