pingcap/tidb

Track memory usage in pessimistic locking phase

Open

#51,217 opened on Feb 21, 2024

View on GitHub
 (5 comments) (0 reactions) (1 assignee)Go (40,090 stars) (6,186 forks)batch import
good first issuetype/enhancement

Description

Enhancement

part of #49643 image The memory consumed in InitCheckExistence in the graph is not tracked by the memory tracker.

Contributor guide

Tech stack
go
Domain
databaseperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go knowledgeDatabase internalsMemory tracking concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
This issue is part of #49643 and requires tracking memory consumption during the InitCheckExistence step in the pessimistic locking phase. First, study how memory tracking is currently implemented in TiDB (e.g., using the memory tracker). Then, identify where InitCheckExistence is called and how to attach the tracker. The commit history and related files (likely in the `store` or `txn` packages) may provide context.