pingcap/tidb

remove the XXXSorter to improve sort performance

Open

#36,058 opened on Jul 8, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Go (6,186 forks)batch import
good first issuetype/enhancement

Repository metrics

Stars
 (40,090 stars)
PR merge metrics
 (Avg merge 14d 4h) (346 merged PRs in 30d)

Description

Enhancement

We have many place to use the exp/slices to sort our struct. It can improve performance by using pdqsort and clean branch check. But We have many placement using the old sort. Please remove it. Here is the example .

BTW, You haven't to change the bazel.build. it can be updated by robot.

  • #36061
  • #36062
  • #36063
  • #36064

Contributor guide

Research direction
Identify all usages of sort.Interface based sorter implementations for structs (e.g., XXXSorter) and replace them with slices.SortFunc using pdqsort for better performance. Follow the pattern in PR #34404. Ensure tests pass and benchmark if needed.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65