pingcap/tidb

Make a case for supporting other characters, such as the GB 18030 character set

Open

#31,688 opened on Jan 14, 2022

View on GitHub
 (0 comments) (1 reaction) (1 assignee)Go (40,090 stars) (6,186 forks)batch import
help wantedtype/feature-request

Description

  • #31690
  • #31692
  • Support gb18030_bin collation
    • #31693
    • Support gb18030_bin collation in Coprocessor
  • Support gb18030_chinese_ci collation
    • #31694
    • Support gb18030_chinese_ci collation in Coprocessor

Support gb18030_unicode_520_ci sort (currently not required)

Contributor guide

Tech stack
gosql
Domain
database
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingDatabase collation conceptsTiDB coprocessor
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Examine existing collation implementations like utf8 bin and utf8 general ci in the TiDB codebase. Look at the Coprocessor module for how collations are handled in push down expressions. Focus on the gb18030 bin and gb18030 chinese ci collations and follow the patterns established. Check the related issues #31693 and #31694 for prior work. Consider testing with various GB18030 characters.