pingcap/tidb

DDL: some DDL logs with `deltaSchemaInfo` cannot be printed correctly

Open

#27,517 opened on Aug 23, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (40,090 stars) (6,186 forks)batch import
help wantedseverity/moderatesig/sql-infratype/bug

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

The structure deltaSchemaInfo cannot be printed correctly:

[2021/08/19 18:48:36.493 +08:00] [Info] [schema_validator.go:174] ["the schema version is much older than the latest version"] [currVer=5148] [latestSchemaVer=5149] [deltas="[{}]"]

image

2. What did you expect to see? (Required)

3. What did you see instead (Required)

[{}]

4. What is your TiDB version? (Required)

v4.0.13

Contributor guide

Tech stack
gosql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingTiDB DDL internalslogging basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate why the `deltaSchemaInfo` struct is printed as empty `[{}]` in logs. Look at `schema validator.go` around line 174, specifically the log statement that prints `deltas`. Check if the struct implements `Stringer` or if the logging format is correct. Review how other similar structures are logged for consistency. Consider using a custom formatter or adjusting the logging message to include actual field values.