pingcap/tidb

Duplicated definition or Non-normalized message of error code

Open

#27,298 opened on Aug 17, 2021

View on GitHub
 (2 comments) (0 reactions) (2 assignees)Go (40,090 stars) (6,186 forks)batch import
help wantedseverity/moderatesig/sql-infratype/bug

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

cd $working_dir/tidb && tools/check/check-errdoc.sh

2. What did you expect to see? (Required)

Generate successfully

3. What did you see instead (Required)

Generate successfully, output:
Duplicated error code: ddl:8200
Duplicated error code: ddl:8200
Duplicated error code: ddl:8200
Duplicated error code: ddl:8200
Non-normalized error: scan break error
Duplicated error code: types:1292
Non-normalized error: can not add because sorted
Duplicated error code: ddl:1273
Non-normalized error: insert statement not found
Non-normalized error: proto: negative length found during unmarshaling
Non-normalized error: proto: integer overflow
Non-normalized error: proto: unexpected end of group
Non-normalized error: label constraint should be in format '{+|-}key=value'
Non-normalized error: unsupported label constraint
Non-normalized error: conflicting label constraints
Non-normalized error: label constraints in map syntax have invalid replicas
Non-normalized error: invalid label constraints format
Non-normalized error: label constraints with invalid REPLICAS
Non-normalized error: invalid bundle ID
Non-normalized error: invalid bundle ID format
Non-normalized error: REPLICAS must be 1 if ROLE=leader
Non-normalized error: the ROLE field is not specified
Non-normalized error: no rule of such role to drop
Duplicated error code: planner:8108
Non-normalized error: retryable: lock not found
Non-normalized error: retryable: already rollback
Non-normalized error: retryable: replaced by another transaction
Duplicated error code: planner:1046
Non-normalized error: Pattern not match
Non-normalized error: invalid syntax

4. What is your TiDB version? (Required)

master

Contributor guide

Tech stack
go
Domain
backendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programming basicsFamiliarity with TiDB error codesBasic shell scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue reports duplicated and non normalized error codes detected by the script `tools/check/check errdoc.sh`. The output lists error codes like ddl:8200, types:1292, planner:8108, etc., along with non normalized messages. To fix, locate each error definition in the TiDB source code (likely in Go files under relevant packages), remove duplicate definitions, and ensure all error messages are normalized (e.g., using format strings). The script runs in the repository root, so understanding the error documentation generation process is helpful.
Duplicated definition or Non-normalized message of error code · pingcap/tidb#27298 | Good First Issue