pingcap/tidb

`host` recognition problem in `create user` statement

Open

#20,592 opened on Oct 22, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Go (40,090 stars) (6,186 forks)batch import
component/privilegegood first issueseverity/moderatesig/sql-infratype/bug

Description

tidb： Note that there is a line break operation in create user and host. There are also line breaks in the user table And when I delete this user also need to have a line break

image image

tidb version: ` MySQL [(none)]> select tidb_version(); +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | tidb_version() | +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ | Release Version: v4.0.1 Edition: Community Git Commit Hash: 689a6b6439ae7835947fcaccf329a3fc303986cb Git Branch: heads/v4.0.1 UTC Build Time: 2020-06-15 03:54:18 GoVersion: go1.13 Race Enabled: false TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306 Check Table Before Drop: false | +----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+ 1 row in set (0.00 sec)

MySQL [(none)]> `

in mysql ：

image

I hope to see at least the same feedback as mysql

Thank U！！！

Contributor guide

Tech stack
gosqlmysql
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingSQL parsingTiDB codebase basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the SQL parser and lexer in the `parser/` directory of TiDB. Focus on how the `CREATE USER` statement tokenizes the host part, and determine if line breaks are correctly handled. Compare with MySQL's behavior to identify the discrepancy. The fix likely involves adjusting the grammar rules or tokenizer to ignore whitespace including line breaks in the host specifier.