pingcap/tidb

Add Slow Query QPS Metrics

Open

#18,708 opened on Jul 21, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (6,186 forks)batch import
component/metricsfeature/acceptedhelp wantedtype/feature-request

Repository metrics

Stars
 (40,090 stars)
PR merge metrics
 (Avg merge 14d 4h) (346 merged PRs in 30d)

Description

Feature Request

Is your feature request related to a problem? Please describe:

At present, TiDB prints all the queries whose execution time exceeds @@tidb_slow_log_threshold(300 ms by default) to the slow query log. In some cases, users want to monitor the slow query QPS to monitor the database performance over time.

Describe the feature you'd like:

Add slow query QPS metrics, display it to Grafana or other monitors.

  • Category: Feature, Usability
  • Value: Make it easier for performance diagnosis
  • Value Score: 3

Describe alternatives you've considered:

N/A

Teachability, Documentation, Adoption, Migration Strategy:

N/A

Contributor guide

Research direction
Study how TiDB logs slow queries and exposes metrics via Prometheus. Then implement a new metric for slow query QPS in the existing metrics system.
Tech stack
go
Domain
databaseobservability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70