pingcap/tidb

P2-[4.0 bug hunting]-[SELECT query]-Wrong error returned

Open

#17,751 opened on Jun 5, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (6,186 forks)batch import
challenge-programhelp wantedseverity/minorsig/executiontype/bug

Repository metrics

Stars
 (40,090 stars)
PR merge metrics
 (Avg merge 14d 4h) (346 merged PRs in 30d)

Description

Description

Bug Hunter issue tidb-challenge-program/bug-hunting-issue#75

Bug Report

1. What did you do?

mysql> select * from user where user((((((((((((((((((((( True ) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR  False )) AND ((( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) OR  False )) AND ((( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) OR  False )) AND ((( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) AND (( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) AND (( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))) AND (((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) AND (( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND ((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) AND (( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) AND (( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND (( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND ((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) AND (( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))))) AND ((( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) AND (( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) AND (( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND ((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) AND ((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) AND ((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))))) AND ((((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))))) AND (((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) OR (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))));
ERROR 1582 (42000): Incorrect parameter count in the call to native function 'user

2. What did you expect to see?

mysql> select * from user where user((((((((((((((((((((( True ) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR  False )) AND ((( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) OR  False )) AND ((( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) OR  False )) AND ((( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) OR  False )) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) AND (( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) AND (( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))) AND (((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) AND (( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND ((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) AND (( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) AND (( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND (( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND ((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) AND (( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))))) AND ((( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) AND (( 1 <=( 4751 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) AND (( 1 <=( 4751 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND ((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) AND ((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) AND ((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR (( 1856 = 7703761045 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))))) AND ((((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ( 1 <=( 4751 ))) OR ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 )))))) AND (((( 1856 = 7703761045 )) OR (( 1856 = 7703761045 )) OR ( 1 <=( 4751 ))) OR (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))) AND ((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR (( 1856 = 7703761045 ))))));
ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(((((((((((((((((((( True ) AND (((( 1856 = 7703761045 )) OR ( 1 <=( 4751 )) OR ' at line 1

3. What did you see instead?

ERROR 1582 (42000): Incorrect parameter count in the call to native function 'user'

4. What version of TiDB are you using? (tidb-server -V or run select tidb_version(); on TiDB)

mysql> select tidb_version();
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| tidb_version()                                                                                                                                                                                                                                                                                        |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Release Version: v4.0.0-rc
Git Commit Hash: 79db9e30ab8f98ac07c8ae55c66dfecc24b43d56
Git Branch: heads/refs/tags/v4.0.0-rc
UTC Build Time: 2020-04-08 07:32:25
GoVersion: go1.13
Race Enabled: false
TiKV Min Version: v3.0.0-60965b006877ca7234adaced7890d7b029ed1306
Check Table Before Drop: false |
+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

SIG slack channel

#sig-exec

Score

  • 300

Mentor

  • @lzmhhh123

Contributor guide

Research direction
Examine how the expression parser handles function calls and their arguments, specifically for the USER() function. Identify where the parser should detect a syntax error instead of a function parameter error.
Tech stack
go
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50