pingcap/tidb

`show grants` statement should contain the privilege informations for create bindings

Open

#16,749 opened on Apr 23, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (40,090 stars) (6,186 forks)batch import
component/bindinfocomponent/privilegeepic/sql-plan-managementfeature/acceptedhelp wantedtype/feature-request

Description

Feature Request

tidb(localhost:4000) > show grants for root;
+-------------------------------------------------------------+
| Grants for root@%                                           |
+-------------------------------------------------------------+
| GRANT ALL PRIVILEGES ON *.* TO 'root'@'%' WITH GRANT OPTION |
+-------------------------------------------------------------+
1 row in set (0.00 sec)

Grants for user doesn't show privilege info for bindings. But we have checked permission for users to create bindings.

Contributor guide

Tech stack
gosql
Domain
databasesecurity
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingTiDB architecture understandingprivilege system knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the current implementation of SHOW GRANTS in TiDB, specifically in the privilege package. Look for how bindings privileges are checked (e.g., in `server/privilege/` or `planner/core/`). Examine the privilege check for creating bindings and see why it's not reflected in SHOW GRANTS. The fix likely involves adding the binding privilege information to the grants output, referencing existing patterns for other privileges.