pingcap/tidb

`show bindings` returns session bindings and global bindings

Open

#16,747 opened on Apr 23, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (40,090 stars) (6,186 forks)batch import
component/bindinfoepic/sql-plan-managementfeature/acceptedhelp wantedtype/feature-request

Description

Feature Request

We have three ways to get bindings:

show bindings;
show session bindings;
show global bindings;

For now, show bindings is equivalent to show session bindings, we'd better to make show bindings return both session bindings and global bindings.

Contributor guide

Tech stack
gosql
Domain
databasebackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Go programmingSQL execution contextTiDB binding internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue requests that 'show bindings' return both session and global bindings instead of only session bindings. Investigate the current implementation of 'show bindings' in the TiDB codebase, likely in the executor package (e.g., show executor.go or similar). Look at how 'show session bindings' and 'show global bindings' are handled separately. The change likely involves modifying the executor to merge results from both sources. Check if there are any existing tests for these commands in the test suite. The ticket has no linked PRs or recent activity, so it is available but may require familiarization with the bindings management system.