pingcap/tidb

Failed Query OPM only counts the error count for ComQuery

Open

#16,384 opened on Apr 15, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (40,090 stars) (6,186 forks)batch import
component/metricshelp wantedseverity/minorsig/executiontype/bug

Description

Bug Report

Now, we count the error count in handleQuery which is only valid for ComQuery. Actually, we should count the error for all commands. Or, some errors may be lost if the command is not ComQuery.

https://github.com/pingcap/tidb/blob/master/server/conn.go#L1270-L1287

Contributor guide

Tech stack
go
Domain
backendobservabilitydatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GoServer side error handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Investigate the error counting logic in handleQuery at server/conn.go lines 1270-1287. Understand how errors are currently counted only for ComQuery and determine the appropriate place to count errors for all commands. Consider modifying the main command handler to increment error count for every failed command, not just ComQuery. Ensure that the change does not double count errors or break existing behavior.