pingcap/tidb

Failed Query OPM only counts the error count for ComQuery

Open

#16,384 opened on Apr 15, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (6,186 forks)batch import
component/metricshelp wantedseverity/minorsig/executiontype/bug

Repository metrics

Stars
 (40,090 stars)
PR merge metrics
 (Avg merge 14d 4h) (346 merged PRs in 30d)

Description

Bug Report

Now, we count the error count in handleQuery which is only valid for ComQuery. Actually, we should count the error for all commands. Or, some errors may be lost if the command is not ComQuery.

https://github.com/pingcap/tidb/blob/master/server/conn.go#L1270-L1287

Contributor guide

Research direction
Inspect handleQuery in conn.go and trace how error counts are currently incremented. Identify all command handlers and determine a common point to count errors for all commands.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75