pingcap/tidb

metrics for tikv client should distinguish TiKV and TiFlash

Open

#16,107 opened on Apr 7, 2020

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Go (6,186 forks)batch import
component/coprocessorcomponent/metricsfeature/acceptedhelp wantedtype/feature-request

Repository metrics

Stars
 (40,090 stars)
PR merge metrics
 (Avg merge 18d 2h) (292 merged PRs in 30d)

Description

Feature Request

Is your feature request related to a problem? Please describe:

For now, the metrics of the tikv client statistics some infos like "backoff seconds", "cop_duration_seconds" and etc. are all named tikvclient. That's not friendly with TiFlash. We'd better distinguish them.

labels need to expand:

  • "txn_cmd_duration_seconds"
  • "backoff_seconds"
  • "request_seconds"
  • "cop_duration_seconds"
  • "region_err_total"
  • "txn_regions_num"
  • "pending_batch_requests"
  • "batch_wait_duration"
  • "batch_client_unavailable_seconds"

Contributor guide

Research direction
The issue requests expanding labels for multiple metrics in the tikv client to distinguish TiKV and TiFlash. Look at the existing metric definitions in the Go codebase (likely under a metrics or client package). Each metric may need a 'store type' label. Since the issue has an assignee, check if any related work is in progress. The changes are iterative and localized.
Tech stack
goprometheus
Domain
observabilitybackend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoPrometheus metrics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35