pingcap/tidb

Move the check for `_tidb_rowid` from executor to planner

Open

#14,221 opened on Dec 25, 2019

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Go (6,186 forks)batch import
help wantedtype/enhancement

Repository metrics

Stars
 (40,090 stars)
PR merge metrics
 (Avg merge 14d 4h) (346 merged PRs in 30d)

Description

Feature Request

Describe the feature you'd like:

Currently we check the _tidb_rowid in executor: https://github.com/pingcap/tidb/blob/57ecfb9b466392853200e9ffebcdd6ebf631ab91/executor/update.go#L284-L293 https://github.com/pingcap/tidb/blob/57ecfb9b466392853200e9ffebcdd6ebf631ab91/executor/insert_common.go#L135-L142

It's better to check this in planer.

Contributor guide

Research direction
Inspect the two locations in executor/update.go and executor/insert common.go where tidb rowid is checked. Understand how the planner currently handles this constraint and move the check to the planner's logical optimization phase.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoTiDB execution and planning concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70