pingcap/tidb

Move the check for `_tidb_rowid` from executor to planner

Open

#14,221 opened on Dec 25, 2019

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Go (40,090 stars) (6,186 forks)batch import
help wantedtype/enhancement

Description

Feature Request

Describe the feature you'd like:

Currently we check the _tidb_rowid in executor: https://github.com/pingcap/tidb/blob/57ecfb9b466392853200e9ffebcdd6ebf631ab91/executor/update.go#L284-L293 https://github.com/pingcap/tidb/blob/57ecfb9b466392853200e9ffebcdd6ebf631ab91/executor/insert_common.go#L135-L142

It's better to check this in planer.

Contributor guide

Tech stack
go
Domain
backenddatabase
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
GoTiDB codebase knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests moving the check for ` tidb rowid` from executor files (executor/update.go and executor/insert common.go) to the planner. The maintainer has assigned someone, indicating work may be in progress. To proceed, first examine the current logic in the executor files linked in the issue, then understand how similar checks are performed in the planner package. The goal is to relocate the validation without changing behavior. Check for any existing planner tests that might need updating.