pingcap/tidb

Error should be thrown when there's ASC/DESC with GROUP BY clause

Open

#10,522 opened on May 17, 2019

View on GitHub
 (8 comments) (0 reactions) (1 assignee)Go (6,186 forks)batch import
help wantedpriority/P4sig/plannertype/feature-request

Repository metrics

Stars
 (40,090 stars)
PR merge metrics
 (Avg merge 14d 4h) (346 merged PRs in 30d)

Description

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.
CREATE TABLE t1 (id INTEGER, sex CHAR(1));
SELECT sex, AVG(id), ROW_NUMBER() OVER w FROM t1
GROUP BY sex ASC
WINDOW w AS () ORDER BY sex DESC;
  1. What did you expect to see?

Error ASC or DESC with GROUP BY isn't allowed with window functions; put ASC or DESC in ORDER BY is thrown.

  1. What did you see instead?

Execute successfully with no warning.

  1. What version of TiDB are you using (tidb-server -V or run select tidb_version(); on TiDB)?

Contributor guide

Research direction
Check the parser or semantic analysis for GROUP BY clause to forbid ASC/DESC when window functions are present.
Tech stack
go
Domain
database
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75