In `avro-enable-watermark=true` using AWS Glue Schema Registry, "DELETE" event and normal event has colliding magic byte
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 72/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- aws, go
- Domain
- backend, data-engineering
Research direction
Start with the referenced byte definitions in pkg/sink/codec/avro/helper.go and pkg/sink/codec/avro/glue_schema_registry.go, then trace the identification logic in pkg/sink/codec/avro/decoder.go. Confirm which internal-use bytes collide with AWS Glue's header version byte, update the internal values without overlapping Glue messages, and verify that DELETE and normal events are distinguished when avro-enable-watermark and AWS Glue Schema Registry are both enabled.
Written by the indexing model from the issue text.
Description
deleteByte is 3
The headerVersionByte of a Glue message is also 3
This will lead to mis-identification when both avro-enable-watermark and AWS Glue Schema Registry are used, e.g.
I suggest changing the 3 internal-use bytes to some value far away from these magic bytes, and probably don't occupy three slots for internal use. Maybe change to e.g. cd c1, cd c2, cd c3.
(Internal reference: GTOC-8564/NAID-12126)
- Dominant language
- Go
- Stars
- 56
- Forks
- 63
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 43
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pingcap/ticdc
-
type/feature-request
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
contribution type/enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
component/test severity/minor type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
severity/major type/bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 84/100
-
enhancement needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
kind/cleanup
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
kubernetes-sigs/kueue#15947 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
sympozium-ai/sympozium#627 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100