BooleansInCondition doesn't respect checkExplicitMixed/checkImplicitMixed config
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 42/100
Research direction
Start with src/Rules/BooleansInConditions/BooleanRuleHelper.php, especially the mixed-type handling around lines 25–27, and compare the two linked PHPStan reproductions. Determine how checkExplicitMixed and checkImplicitMixed should affect the rule, then verify that both explicit and implicit mixed conditions follow the selected behavior.
Written by the indexing model from the issue text.
Description
Booleans in condition report explicitMixed in level 7
https://phpstan.org/r/954e86c5-1a77-43e9-a4c7-c96f9c66b1fe
But doesn't report implicitMixed in level 10
https://phpstan.org/r/865a7467-a5f4-46c3-a95f-b592db7e2f9e
This is because BooleanRuleHelper has a custom behavior for mixed
https://github.com/phpstan/phpstan-strict-rules/blob/a4a6a08bd4a461e516b9c3b8fdbf0f1883b34158/src/Rules/BooleansInConditions/BooleanRuleHelper.php#L25-L27
I think it should rely on explicitMixed/implicitMixed config instead.
Option 1:
Chaning nothing
Option2:
Using both checkExplicitMixed/checkImplicitMixed config
if ($type instanceof MixedType) {
if ($type->isExplicitMixed()) {
return !$this->checkExplicitMixed;
} else {
return !$this->checkImplicitMixed;
}
}
Option3:
Keeping the behavior for explicitMixed but allow to report implicitMixed.
if ($type instanceof MixedType) {
return !$type->isExplicitMixed() && !$this->checkImplicitMixed;
}
I would go with option 2, but it's your call @ondrejmirtes
- Dominant language
- PHP
- Stars
- 709
- Forks
- 62
- Avg merge
- 5d 19h
- Merged PRs (30d)
- 3
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from phpstan/phpstan-strict-rules
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
phpstan/phpstan-strict-rules#317 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
phpstan/phpstan-strict-rules#316 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 52/100
phpstan/phpstan-strict-rules#298 · 2 comments · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
phpstan/phpstan-strict-rules#289 · 1 comment ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
phpstan/phpstan-strict-rules#283 · 6 comments ·
All issues in phpstan/phpstan-strict-rules
Similar issues
-
priority: p3
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
googleapis/librarian#7636 ·
-
0. Needs triage bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
nextcloud/fulltextsearch#1011 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
coollabsio/coolify#11927 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100