Component type is not tracked when hyphen notation is used

Open
#147 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
php
Domain
devtools

Research direction

Start with the four component-access examples in the issue and trace how component types are tracked for bracket and hyphen notation. Resolve whether hyphen notation should infer HeadControl like the other forms or be explicitly unsupported; done when the chosen behavior is consistently reported.

Written by the indexing model from the issue text.

Description

Sub-components accessed via hyphen notation are treated as mixed

$this['document']['head'];
$this['document-head'];
$this->getComponent('document')->getComponent('head');
$this->getComponent('document-head');

Current result

  1     Dumped type: HeadControl
  2     Dumped type: mixed~null
  3     Dumped type: HeadControl
  4     Dumped type: mixed~null

Expected result:

All should return HeadControl. Or report that this syntax is not supported.
Which variant would you prefer?

Dominant language
PHP
Stars
118
Forks
44
Avg merge
17d 5h
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phpstan/phpstan-nette

All issues in phpstan/phpstan-nette

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.