Deprecate a single parameter

Open
#164 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
google-cloud, php
Domain
tooling

Research direction

Start with the linked google-cloud-php-storage StorageClient.php source and inspect how this repository currently handles deprecations for constructor parameters and constructors. Identify the intended handling for this upstream change, then verify it against the repository's existing checks; the issue names no local file or test, so the completion criteria need clarification.

Written by the indexing model from the issue text.

Description

Hey,

Google Cloud Storage has deprecated a single parameter: https://github.com/googleapis/google-cloud-php-storage/blob/4b81b682f6b1517c0c5f6152b2980195d23c1cef/src/StorageClient.php#L100

Now the entire constructor is marked as deprecated for this extension. Anything we could do here properly instead of ignoring at all?

Dominant language
PHP
Stars
462
Forks
25
Avg merge
8d 18h
Merged PRs (30d)
1

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phpstan/phpstan-deprecation-rules

All issues in phpstan/phpstan-deprecation-rules

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.