phpmyadmin/phpmyadmin

Move HTTP request superglobals access to controllers

Open

#16,276 opened on Jul 22, 2020

View on GitHub
 (2 comments) (1 reaction) (0 assignees)PHP (3,454 forks)batch import
good first issuehacktoberfesthelp wantednewbierefactoring

Repository metrics

Stars
 (6,886 stars)
PR merge metrics
 (Avg merge 2d 17h) (11 merged PRs in 30d)

Description

Superglobals like $_POST, $_GET and $_REQUEST should be moved to controllers.

Contributor guide

Research direction
Identify all usages of superglobals ($ POST, $ GET, $ REQUEST) outside controllers in the codebase and move them into appropriate controller methods.
Tech stack
php
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65