phpmyadmin/phpmyadmin

inline editing in "select distinct" does not quote the values correctly

Open

#15,523 opened on Oct 23, 2019

View on GitHub
 (7 comments) (0 reactions) (0 assignees)PHP (3,454 forks)batch import
Bughelp wantedwaiting on upstream

Repository metrics

Stars
 (6,886 stars)
PR merge metrics
 (Avg merge 2d 17h) (11 merged PRs in 30d)

Description

Describe the bug

When editing a value inline after running a "select distinct" statement, the values generated by the SQL query have quotes missing, causing SQL error.

To Reproduce

Steps to reproduce the behavior:

  1. Run a "select distinct" statement on a table
  2. Click on a value to edit it
  3. See error

Expected behavior

The value is changed

Screenshots

If applicable, add screenshots to help explain your problem. image

Server configuration

  • Operating system: Debian
  • Web server: Apache
  • Database version: MariaDB 10.3.18
  • PHP version: 7.3.3
  • phpMyAdmin version: 4.9.0.1

Client configuration

  • Browser: Chrome
  • Operating system: Ubuntu

Additional context

Add any other context about the problem here.

Contributor guide

Research direction
Inspect the code responsible for inline editing in the "SELECT DISTINCT" query results to identify where quotation marks are not being added correctly.
Tech stack
php
Domain
databasebackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPSQL
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65