Use griddle's XYCursorChartNode for the MembranePotentialChart

Open
#144 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
data-visualization

Research direction

Start by comparing neuron’s MembranePotentialChart with griddle’s XYCursorChartNode or XYCursorPlotNode, using the energy-skate-park implementation as the reference mentioned in the issue. The work is done when MembranePotentialChart uses the common cursor plot component without losing its existing chart behavior.

Written by the indexing model from the issue text.

Description

A cursor plot was added to griddle that was influenced heavily by the MembranePotentialChart, though used in energy-skate-park.. The MembranePotentialChart could be re-written to use this common component.

Similar to #52, but that issue referenced a few other things mentioned that I wasn't familiar with with so I made this issue just for using XYCursorPlotNode.

Dominant language
JavaScript
Stars
1
Forks
3
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phetsims/neuron

All issues in phetsims/neuron

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.