percona/pmm

Enable `revive` linter rule

Open

#2,344 opened on Jul 3, 2023

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Go (223 forks)auto 404
enhancementgood first issuehacktoberfest

Repository metrics

Stars
 (1,077 stars)
PR merge metrics
 (PR metrics pending)

Description

Description

Ref: #1541 We'd like to enable revive linter rule.

Suggested solution

  • evaluate if we can afford to enable the rule
  • if yes, fix all linter error to make tests pass
  • if not, disable the rule and leave a comment explaining why (subject to review by the dev team)

Additional context

The rule can be enabled by simply removing this line. You can check similar PRs to see how we enabled some other rules (ref: #1541)

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributor guide

Research direction
Remove the line that disables the revive rule in .golangci.yml, run the linter, fix any errors, and ensure tests pass.
Tech stack
go
Domain
backenddeveloper experience
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gogolangci lint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80