percona/pmm

Address the `gocritic` linter warnings

Open

#2,291 opened on Jun 21, 2023

View on GitHub
 (2 comments) (0 reactions) (1 assignee)Go (223 forks)auto 404
enhancementgood first issuehacktoberfest

Repository metrics

Stars
 (1,077 stars)
PR merge metrics
 (PR metrics pending)

Description

Description

We silenced a number of gocritic rule warnings in this PR to reduce the scope. However, addressing some of the warnings could simplify and optimize the code (see this conversation).

Suggested solution

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Contributor guide

Research direction
Identify the gocritic rule warnings that were silenced in the referenced PR (percona/pmm/pull/2281) and check the conversation for specific advice. Then, apply the suggested fixes to simplify and optimize the code.
Tech stack
go
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gogocritic
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60