When building from `SampleYAML`, the sample index column is not cast to `DataType::String` [potential BUG]
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
Research direction
Find the code path that builds a dataframe from SampleYAML and compare it with the CSV branch, which already normalizes the index column. Apply the same index-string normalization shown in the issue, then verify that a numeric YAML index can be used by get_sample(name: &str).
Written by the indexing model from the issue text.
Description
When building from SampleYAML, the sample index column is not cast to DataType::String like the CSV path is. If the YAML parses the index column as a non-string type (e.g. numbers), later lookups like get_sample(name: &str) can fail due to a dtype mismatch. Consider applying the same .lazy().with_column(col(final_index.clone()).cast(DataType::String)).collect()? normalization used in the CSV branch.
let df = resolve_yaml_to_dataframe(&yaml_path)?
.lazy()
.with_column(col(final_index.clone()).cast(DataType::String))
.collect()?;
Originally posted by @Copilot in https://github.com/khoroshevskyi/peprs/pull/43#discussion_r3104373679
- Dominant language
- Rust
- Stars
- 3
- Forks
- 0
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 2
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from pepkit/peprs
-
Difficulty 2/5 1-3 hours Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
-
brainstorming
Difficulty 3/5 1-2 days Newbie friendliness 55/100
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gitbutlerapp/gitbutler#15998 · 1 comment ·
-
bug triage:deciding
Difficulty 1/5 Under an hour Newbie friendliness 88/100
open-telemetry/otel-arrow#4132 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100