pedrovgs/Renderers

Support for LayoutContainer

Open

#46 opened on May 13, 2018

View on GitHub
 (11 comments) (0 reactions) (0 assignees)Java (1,204 stars) (174 forks)batch import
enhancementhelp wanted

Description

As it turns out, Kotlin synthetic properties cache works by default on Activities, Fragments, and Views, but it does not do so for ViewHolder. They fixed this as of Kotlin 1.1.4 via LayoutContainer.

Consumers of this libraries have to make sure they make their Renderers implement LayoutContainer if they are using synthetic properties inside of them. If they do not, their ViewHolders are going to call findViewById() on every call to render() making their ViewHolders obsolete. It would be nice if the library itself did this maybe by adding a Kotlin specific artifact that implements this interface (implementation should be trivial). Thoughts?

Contributor guide

Tech stack
kotlinjavaandroid
Domain
mobile
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
KotlinAndroid RecyclerView
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the Renderer base classes in the repository to understand the current ViewHolder pattern. Review the issue comments for any maintainer feedback on the approach. Then create a new Kotlin module that implements LayoutContainer interface for Renderers by overriding the containerView property. See the Kotlin synthetic properties documentation for reference.