pedrovgs/EffectiveAndroidUI

ButterKnife Fragment unbinding

Open

#26 opened on Mar 21, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (6,030 stars) (1,211 forks)batch import
enhancementhelp wanted

Description

Hey, shouldn't you call ButterKnife.unbind(unbinder) in your BaseFragment's onDestroyView(..) callback?

Contributor guide

Tech stack
javaandroid
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaAndroid SDKButterKnife
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue suggests adding ButterKnife.unbind(unbinder) in the onDestroyView callback of BaseFragment.java. The file is located at app/src/main/java/com/github/pedrovgs/effectiveandroidui/ui/fragment/BaseFragment.java. Currently, the unbind call is missing, which could cause memory leaks or issues with view binding after the fragment's view is destroyed. The fix involves adding a single line after the super call in onDestroyView, using the Unbinder object that is likely already returned from ButterKnife.bind().