pedrovgs/EffectiveAndroidUI

ButterKnife Fragment unbinding

Open

#26 opened on Mar 21, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (1,211 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (6,030 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hey, shouldn't you call ButterKnife.unbind(unbinder) in your BaseFragment's onDestroyView(..) callback?

Contributor guide

Research direction
Add ButterKnife.unbind(unbinder) in the onDestroyView method of BaseFragment.
Tech stack
javaandroid
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AndroidButterKnife
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90