pastelsky/bundlephobia

Getting 404 for empty input

Open

#770 opened on Apr 4, 2023

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (8,477 stars) (250 forks)batch import
buggood first issue

Description

Describe the bug It looks like it is expected behaviour but I don't think we should allow an empty input call from the frontend.

To Reproduce Don't type anything in the search box and press enter. It takes you to https://bundlephobia.com/package which gives 404.

Expected behavior I believe we should just do nothing when the input is empty.

Let me know if the suggested fix is good and I can make a relevant PR for the same.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic javascriptbasic react
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
Examine the search input component (likely in SearchBar.js) to find the form submission handler. Add a conditional check to prevent navigation or API call when the input is empty. Refer to the expected behavior described in the issue.