pasbi/ommpfritt

Regex could be compiled in maincli

Open

#155 opened on Dec 19, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (7 forks)auto 404
good first issueperformance

Repository metrics

Stars
 (46 stars)
PR merge metrics
 (PR metrics pending)

Description

The predicate function is called very often (once for every object in the scene). The same regular expressions are created inside that function every time. Consider to compile the regular expressions outside and capture the regex object instead.

Contributor guide

Research direction
Move the regex compilation outside the predicate function to avoid repeated compilation.
Tech stack
cpp
Domain
desktopperformance
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80