parcel-bundler/parcel

Throw user friendly error if dynamic import isn't JS or empty

Open

#1951 opened on Aug 28, 2018

View on GitHub
 (12 comments) (0 reactions) (0 assignees)JavaScript (44,030 stars) (2,274 forks)batch import
:raising_hand_woman: FeatureGood First Issue

Description

Feature request

Throw a user friendly error if someone is trying to import non JS or empty assets in async imports

Original issue

The following works fine when I run i development mode (parcel index.html)

import myModule from './src/mymodule.js'
import './some.css';

 var assets = {
        html : import('./module.html'),
        css: import('./css.css'),
        js : import("./javascript.js")
      }

 Promise.all([assets.html, assets.css, assets.js]).then(function(values) {
      document.querySelector('.container').innerHTML = values[0];
      values[2]['default'](myModule)
    });

Build runs successfully(parcel build index.html), but when retrieving the build from the server I get:

Uncaught (in promise) Error: Cannot find module 'kgfs'

🤔 Expected Behavior

Should load all modules

😯 Current Behavior

caught (in promise) Error: Cannot find module 'kgfs'

🌍 Your Environment

Software Version(s)
Parcel da7eeb69552a849a26f51a305f42821337bf90e5
Node 8.11.2
npm/Yarn 6.2.0
Operating System windows 10

Contributor guide

Tech stack
javascriptnodejshtmlcss
Domain
build systemtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsJavaScript dynamic imports
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate Parcel's dynamic import handling code, likely in the JavaScript asset resolver. Check the repository's source for where imports are processed. Ensure that non JS/empty imports throw a custom error message instead of the cryptic 'Cannot find module' error. Review comments in the issue for any additional context or proposed solutions.