parallax/jsPDF

Context2D does not implement rect() correctly

Open

#3409 opened on Apr 9, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (28,280 stars) (4,596 forks)batch import
Bugdifficulty:beginnerhelp wanted

Description

It should add a closed subpath with four segments. Instead, it adds an open subpath with six segments.

Contributor guide

Tech stack
javascript
Domain
api
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptcanvas context API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Examine the implementation of rect() in the Context2D prototype, likely in the source file (e.g., src/plugins/canvas.js). The current implementation creates an open subpath with six segments; it should create a closed subpath with four segments. Consult the HTML5 Canvas specification for the correct behavior and adjust the path commands accordingly. No linked PRs or assignees, so this issue is available for contribution.