parallax/jsPDF

Context2D does not implement clip() correctly

Open

#3408 opened on Apr 9, 2022

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (28,280 stars) (4,596 forks)batch import
Feature Requestdifficulty:mediumhelp wanted

Description

clip() is supposed to take an argument to specify the clipping rule. Context2D drops this argument on the floor and implements the default clipping rule, I guess.

It can also be given two arguments where one argument is the path. This is also not implemented.

https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/clip

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
JavaScriptCanvas APIjsPDF internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Explore the Context2D implementation in jsPDF, likely in src/context2d.js or similar. The current clip() method should be located and compared with the MDN specification. The fix needs to handle the optional `fillRule` argument and the two argument variant where the first argument is a path. Look for how other methods like `fill()` or `stroke()` handle similar arguments. Review any existing tests for clip() in the test directory.