papercups-io/papercups

Better phone number filtering for twillio and SMS in integrations page

Open

#816 opened on May 5, 2021

View on GitHub
 (3 comments) (0 reactions) (1 assignee)Elixir (6,032 stars) (566 forks)batch import
enhancementgood first issue

Description

Problem Right now if you enter a phone number without the area code or have the wrong formatting in phone number section it will fail silently and not work. We should make sure that there is a country code and that it can work regardless of the text formatting

Solution It should validate that it has a country code and we shouldn't care about formatting

Contributor guide

Tech stack
elixir
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Elixir basicsphone number validation concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the current phone number input handling in the integrations page, likely in a Phoenix template or LiveView. Look for validation logic in lib/ or web/ directories. Consider using a library like ex phone number or implementing a simple regex for country code presence. Check comments for any existing discussions on preferred approach. The issue specifies ignoring formatting, so focus on stripping non digit characters and ensuring a length that implies a country code (e.g., >= 10 digits).