panzarino/mlbgame

Stop converting HTTPError to ValueError in mlbgame/data.py

Open

#92 opened on Apr 27, 2018

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Python (509 stars) (116 forks)batch import
enhancementhelp wantedquestion

Description

Converting HTTPError to ValueError loses valuable information about the failure. If the HTTPError itself was allowed to be raised then callers could look at the status code and determine if they want to try the call again (in the case of a 5xx error) or stop trying (4xx error).

Or maybe it could raise new exceptions defined by the mlbgame library? Fatal or Retryable?

Contributor guide

Tech stack
python
Domain
backendapi
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
understanding of Python exception handlingbasic knowledge of HTTP status codes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Look at `mlbgame/data.py` where `HTTPError` is caught and converted to `ValueError`. The issue suggests either letting the original `HTTPError` propagate or defining custom exceptions like `Fatal` or `Retryable`. Check the existing exception hierarchy in the codebase and decide which approach aligns with the library's design. Also review any comments in the issue for further discussion.
Stop converting HTTPError to ValueError in mlbgame/data.py · panzarino/mlbgame#92 | Good First Issue