panzarino/mlbgame

ValueError: Could not find a game with that id.

Open

#52 opened on Jan 17, 2018

View on GitHub
 (21 comments) (0 reactions) (0 assignees)Python (116 forks)batch import
bugenhancementhelp wanted

Repository metrics

Stars
 (509 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Running the same code as before:

def team_games(year,month):
    month = mlbgame.games(year, month)
    games = mlbgame.combine_games(month)
    for game in games:
        print game.game_id
    return games


games = team_games(2016, 5)

and its breaking on random game ids when iterating through.

This one in particular breaks:

stats = mlbgame.team_stats('2016_05_16_bosmlb_kcamlb_1')
era = stats.home_pitching.era
print(era)

Status is also FINAL

Contributor guide

Research direction
Trace the code for team stats and examine the data retrieval pipeline for the specific game ID to understand why it fails.
Tech stack
python
Domain
dataapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonmlbgame library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70