panzarino/mlbgame

ValueError: Could not find a game with that id.

Open

#52 opened on Jan 17, 2018

View on GitHub
 (21 comments) (0 reactions) (0 assignees)Python (509 stars) (116 forks)batch import
bugenhancementhelp wanted

Description

Running the same code as before:

def team_games(year,month):
    month = mlbgame.games(year, month)
    games = mlbgame.combine_games(month)
    for game in games:
        print game.game_id
    return games


games = team_games(2016, 5)

and its breaking on random game ids when iterating through.

This one in particular breaks:

stats = mlbgame.team_stats('2016_05_16_bosmlb_kcamlb_1')
era = stats.home_pitching.era
print(era)

Status is also FINAL

Contributor guide

Tech stack
python
Domain
backendapidata
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Python programmingFamiliarity with mlbgame library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the team stats function in the mlbgame source code to understand how it handles game IDs. Compare the failing game ID '2016 05 16 bosmlb kcamlb 1' with other working IDs to identify format differences or missing data. Check the underlying MLB GameDay data source for that specific game to see if the data is incomplete or the URL is malformed. Review issue comments for any hints or partial solutions from previous discussions.