panzarino/mlbgame

overview(game_id) causes XMLSyntaxError

Open

#133 opened on Jun 4, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (116 forks)batch import
bughelp wanted

Repository metrics

Stars
 (509 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

If I cycle through 'mlbgame.day()' with today's date I receive a list of all the games, including the 'game_id'. If I use that 'game_id' and try and use 'mlbgame.overview(game_id)', I receive the following error:

File "http://gd2.mlb.com/components/game/mlb/year_2019/month_06/day_04/gid_2019_06_04_atlmlb_pitmlb_1/rawboxscore.xml", line 1 lxml.etree.XMLSyntaxError: Space required after the Public Identifier, line 1, column 55

I have tried this with games in the past as well and still receive the same error.

I'm kind of new to Python, so there's a chance I'm doing something wrong.

Contributor guide

Research direction
Check the raw URL 'http://gd2.mlb.com/components/game/mlb/year 2019/month 06/day 04/gid 2019 06 04 atlmlb pitmlb 1/rawboxscore.xml' in a browser to see if the XML is malformed or if the server returns an error page. Then trace the code in mlbgame.overview to understand how it fetches and parses the XML. Consider using try except for XML parsing errors.
Tech stack
python
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75