palantir/blueprint

Background elements of Dialog/Drawer should be unfocus-able and hidden. Headers in background should not show up in screenreader heaver navigation

Open

#6756 opened on Apr 4, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: accessibilityStatus: needs proposalType: bughelp wanted

Description

Environment

  • Package version(s): 5.8.2
  • Browser and OS versions: Edge, Chrome, MacOS Sonoma 14.4

Feature request

When a Dialog or Drawer is open, the background elements should be un-focusable and hidden. This is backed up by this source and this source. Otherwise, the screenreader cursor could focus on something behind the Dialog/Drawer.

Examples

Currently when navigating by headings (CTRL+OPT+U on Mac) using a screenreader, currently when a Dialog or Drawer is open, the headers in the content underneath the overlay are also included in header navigation, which is unexpected.

Contributor guide

Tech stack
typescriptreacthtmlcss
Domain
frontendaccessibility
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactARIAfocus managementBlueprint components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the Dialog and Drawer components in the Blueprint source code (likely under packages/core/src/components/dialog/ and drawer/). Determine how to apply `aria hidden="true"` to the root container or sibling elements when a dialog is open, and ensure focus trapping is implemented correctly. Refer to the WAI ARIA pattern for modal dialogs linked in the issue. No linked PRs or comments are available yet.