palantir/blueprint

FR: Add `popoverProps` property to `TruncatedFormatProps`

Open

#6,667 opened on Jan 23, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
P2Package: tableType: feature requesthelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Environment

  • Package version(s): ^5.8.2
  • Browser and OS versions: Chrome 120.0.6099.234 & MacOS 14.2.1

Feature request

Add popoverProps property to TruncatedFormatProps

Examples

Currently, when using JSONFormat with detectTruncation=true and showPopover=true, the popover has some confusing behaviour. Would be nice to have options to configure the popover's behaviour (eg. setting interactionKind to HOVER_TARGET_ONLY to simply avoid these interactions)

  • Right clicking on the popover makes it look like you're copying the popover text but it's actually selecting the cell underneath

  • Highlighting some popover text and then cmd+c looks like you're copy/pasting the highlighted substring, but it's actually copy/pasting the entire cell

Contributor guide

Research direction
Examine the TruncatedFormat component implementation to understand how popover is currently configured. Look at other Blueprint components that accept popoverProps (e.g., Tooltip) for pattern reference. Then add a popoverProps prop to TruncatedFormatProps and pass it to the underlying Popover component.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60