palantir/blueprint

FR: Add `popoverProps` property to `TruncatedFormatProps`

Open

#6667 opened on Jan 23, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: tableType: feature requesthelp wanted

Description

Environment

  • Package version(s): ^5.8.2
  • Browser and OS versions: Chrome 120.0.6099.234 & MacOS 14.2.1

Feature request

Add popoverProps property to TruncatedFormatProps

Examples

Currently, when using JSONFormat with detectTruncation=true and showPopover=true, the popover has some confusing behaviour. Would be nice to have options to configure the popover's behaviour (eg. setting interactionKind to HOVER_TARGET_ONLY to simply avoid these interactions)

  • Right clicking on the popover makes it look like you're copying the popover text but it's actually selecting the cell underneath

  • Highlighting some popover text and then cmd+c looks like you're copy/pasting the highlighted substring, but it's actually copy/pasting the entire cell

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptBlueprint components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Locate the `TruncatedFormat` component in the Blueprint source code (likely in `packages/core/src/components/truncated format/`). Examine the current `TruncatedFormatProps` interface and the internal rendering of the Popover. Implement the `popoverProps` prop as an optional object that spreads onto the Popover component. Ensure type safety with TypeScript. Add appropriate documentation and update any relevant tests. No existing PRs or comments clarify the implementation approach.