palantir/blueprint

EditableCell2 doesn't rerender to empty cell on sort.

Open

#6602 opened on Dec 13, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Package: tableStatus: needs proposalType: bughelp wanted

Description

Environment

  • Package version(s): "@blueprintjs/core": "^5.5.1", "@blueprintjs/table": "^5.0.20",
  • Operating System: Windows 11
  • Browser name and version: Firefox 120.0.1 (64 bit), Chrome 120.0.6099.71 (64 bit)

Code Sandbox

demo

Steps to reproduce

  1. Create some table data with some undefined values.
  2. Create a sortable Table2 whose cells are EditableCell2.
  3. Sort columns with undefined cells. When a cell value changes from some value to undefined, it does not re-render to a blank cell.

Actual behavior

EditableCell2 does not re-render when its value changes from some value to undefined.

Expected behavior

The cell re-renders into a blank cell whenver the value changes to undefined.

Possible solution

.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with ReactUnderstanding of Blueprint table components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
First, locate the EditableCell2 component in the Blueprint table package (likely in packages/table/src/components/editableCell/editableCell.tsx). Investigate how the cell renders its value and whether it uses React.memo or shouldComponentUpdate to prevent re renders when the value changes. The issue is that sorting triggers a re render but the cell does not update when the value becomes undefined. Look for comparisons that treat undefined and a previous string as equal, perhaps due to shallow checking or missing dependency in useEffect.