palantir/blueprint

Add Align-Top and Align-Bottom Icons

Open

#6571 opened on Nov 27, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Package: iconsType: feature requesthelp wanted

Description

Environment

  • Package version(s): 5.7.0
  • Browser and OS versions: Chrome

Feature request

Please can align-top and align-bottom be added to the icons:

As, the alignment-top and alignment-bottom doesn't go with it.

Examples

To assist with this request, I've drafted SVG's that I believe are close to the required pattern:

align_top_20px_icon align_bottom_20px_icon align_bottom_16px_icon align_top_16px_icon

However I couldn't quite figure out the 'BLUEPRINT_ICONS_16_CODEPOINTS' numerical system in order to fully package it for a PR.

Therefore, hoping this is enough for someone to include it, which would be a massive help!

Thanks heaps

Contributor guide

Tech stack
typescriptreactcss
Domain
frontenddesign
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Blueprint icon codepoint system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Research the Blueprint icon codepoint system in the source code (likely in a file like 'iconCodepoints.ts' or similar). Examine existing alignment icons (e.g., align left, align right) to understand naming and size conventions. Add the provided SVGs for align top and align bottom in both 16px and 20px sizes to the appropriate directories. Update the icon index to include the new icons. Test that the icons render correctly in the Blueprint documentation.