palantir/blueprint

[v5] Popover not closing when navigating lazily loaded pages via React Router

Open

#6518 opened on Nov 6, 2023

View on GitHub
 (2 comments) (3 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/core 5.6.0
  • Operating System: Windows 10
  • Browser name and version: Chrome 118

Code Sandbox

https://codesandbox.io/p/sandbox/blueprint5-popover-issue-9zjj9x

Steps to reproduce

  1. Use the navbar menu to navigate to "Page 2"

Actual behavior

When using React Router to navigate to a lazily loaded page, the popover menu does not close and loses interactivity.

Expected behavior

The popover menu should close after the page transition.

Possible solution

No current solution to propose. We're currently migrating our code from Blueprint v4 to v5 and noticed this issue.

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactReact RouterBlueprint v5
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the Popover component's close behavior in the context of React Router navigation with lazy loaded pages. Review the CodeSandbox provided to replicate the issue. Check the Popover's event handling and see if the component unmounts or state changes during navigation. Look for any existing discussions or related issues in the Blueprint repository about popover closing. Possible fix involves ensuring the popover closes when the route changes, perhaps by listening to navigation events or using a key prop.