palantir/blueprint

DateInput3 doesn't regain value when parsing user input

Open

#6482 opened on Oct 20, 2023

View on GitHub
 (2 comments) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P1Package: datetimeType: bughelp wanted

Description

Environment

  • Browser name and version: Chrome 118.0.5993.70
  • Package version: @blueprintjs/datetime2 v2.2.1

Code Sandbox

Reproducible on docs page

Steps to reproduce

  1. Click on a date in the popover to initialize a value (ie "10/25/2023")
  2. Delete a portion of the date component (in this case what could be left would be "10/25").
  3. When retyping the same value in, the date isn't reselected in the popover and clicking out of the input will error.

Actual behavior

Retying the value will throw an out of range or invalid date error, I think depending on the specificity of the time (just the date or including seconds, for example)

2023-10-20_10-44-00 (1)

Expected behavior

The date will be re-selected in the component.

Possible solution

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactTypeScriptcontrolled components
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the DateInput3 component in the Blueprint.js source code, specifically the date parsing and state update logic in the input handler. Look at how the component handles partial dates (e.g., '10/25') and how it restores the selected date when the user retypes the full date. Check the component's test files for existing tests on date parsing and value propagation.