palantir/blueprint

Table hotkeys prevent newlines in text areas in cells

Open

#6425 opened on Oct 3, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: tableType: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/table: 5.0.12
  • Operating System: Mac OS (Intel)
  • Browser name and version: Chrome 117.0.5938.92

Code Sandbox

https://codesandbox.io/p/sandbox/strange-microservice-hgshms

Steps to reproduce

  1. Put a text area in a Cell in a Table2
  2. Try to add a newline to the text area by pressing enter

Actual behavior

Nothing happens

Expected behavior

A new line would be entered

Possible solution

Stop preventing defaults on enter keydown events that happen in the table.

Contributor guide

Tech stack
typescriptreact
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactEvent handlingBlueprint Table
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the Table2 component's keyboard event handling in Blueprint. Look for event listeners that call `preventDefault()` on `keydown` events for the `Enter` key. The fix should check if the event target is a `textarea` element before preventing the default behavior. Common location is in `src/components/table/` or similar. Refer to issue #6425 for reproducibility. Also review the comments for any additional context.