palantir/blueprint

ESLint deprecated component usage detector does not handle aliased imports

Open

#6408 opened on Sep 26, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: toolingP2Type: bughelp wanted

Description

Environment

  • Package version(s): @blueprintjs/eslint-plugin: 5.0.0
  • Operating System: Windows 10/11

Steps to reproduce

  1. Use an aliased import of a deprecated BlueprintJS component somewhere:

import { DateInput as BlueprintDateInput } from "@blueprintjs/datetime";

  1. Use "plugin:@blueprintjs/recommended" in your eslintrc file.

Actual behavior

No errors detected.

Expected behavior

A message which tells that the usage of DateInput is deprecated.

  71:6  error  Usage of DateInput is deprecated, migrate to DateInput3 instead  @blueprintjs/no-deprecated-components

The error is properly displayed if we change the aliased import to a non-aliased import.

Contributor guide

Tech stack
typescriptreact
Domain
frontendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of ESLint plugin developmentFamiliarity with TypeScript AST
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the ESLint rule implementation in @blueprintjs/eslint plugin, likely in the src/rules/no deprecated components directory. The rule needs to handle aliased imports by checking ImportSpecifier nodes where the imported name matches deprecated components, regardless of the local alias. Look for the function that processes ImportDeclaration and modify it to also capture aliased imports. Consider testing with cases like 'import { DateInput as BlueprintDateInput }'.