palantir/blueprint

`eachUniqueFullRow` crashes with header row shift-click

Open

#6383 opened on Sep 15, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: tableType: bughelp wanted

Description

Environment

  • Package version(s): 5.3.0
  • Operating System: MacOS
  • Browser name and version: Chrome 117

Steps to reproduce

  1. Pass a region of { row: [1, Infinity] } to eachUniqueFullRow (this can be caused for example by shift-clicking on a row header cell + using eachUniqueFullRow in the onSelect.

Actual behavior

Spins until tab crashes

Expected behavior

Short circuit or error

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic understanding of Blueprint table componentFamiliarity with the issue's reproduction steps
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the `eachUniqueFullRow` function in the Blueprint table source code, likely in the selection utilities (e.g., src/components/table/). Look for how it handles row ranges and specifically when `Infinity` is passed. Consider adding a guard to check for `Infinity` or bound the row range to the actual number of rows. Check existing tests for similar edge cases.