palantir/blueprint

Focus moves from Select filter to outside page

Open

#6368 opened on Sep 4, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: accessibilityP3Package: selectType: bughelp wanted

Description

Environment

  • Package version(s): 3.5+
  • Operating System: Mac OS 13.5.1
  • Browser name and version: Chrome 115.0.5790.170

Code Sandbox

Link to a minimal repro: https://blueprintjs.com/docs/#select/select-component

Steps to reproduce

  1. Open the select dropdown and click on the filter text input.
  2. Type any random characters to empty out the list.
  3. Hit tab twice and the focus will move to the address bar.

Actual behavior

The focus should move to the next available focusable element.

Contributor guide

Tech stack
typescriptreact
Domain
frontendaccessibility
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
familiarity with React focus managementbasic knowledge of Blueprint's Select component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Focus on the Select component's filter input behavior. Look in the Blueprint source code (likely packages/select/src/) for the component handling tab key events. The issue states that after filtering empties the list, pressing Tab twice moves focus out of the page. Investigate how the component manages focus when the list has no items. Consider implementing a focus trap or cycling focus within the component when the list is empty.