palantir/blueprint

Expanding a tree with many child nodes that have ContextMenu is very slow

Open

#6204 opened on Jun 6, 2023

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Domain: performanceP2Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): The latest @blueprintjs/core@4.20.1, @blueprintjs/popover2@1.14.9
  • Operating System: macOS
  • Browser name and version: Edge/Chrome

Code Sandbox

https://codesandbox.io/p/sandbox/festive-rgb-j35zpp

Actual behavior

If the tree node has many children nodes, and these children nodes are wrapped with ContextMenu2, when expanding the tree node, it's stuck for seconds to expand its children. If the ContextMenu2 is removed, the expanding is very smooth.

The sandbox uses the treeExample from the blueprint itself and makes a little change to demonstrate this problem.

Contributor guide

Tech stack
typescriptreact
Domain
frontendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactPerformance debuggingTree componentContextMenu
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Reproduce the slowdown using the provided CodeSandbox (https://codesandbox.io/p/sandbox/festive rgb j35zpp). Profile the tree expansion with React DevTools to pinpoint the culprit. Inspect the Tree and ContextMenu2 source code in the Blueprint repository to understand the rendering flow. Consider using React.memo or virtualization to reduce the number of context menus rendered at once.